On Thu, 2023-10-26 at 15:03 +0000, Marius.Cristea@xxxxxxxxxxxxx wrote: > Hi Nuno Sá, > > Thanks for looking over the patch. > > On Wed, 2023-10-25 at 16:38 +0200, Nuno Sá wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you > > know the content is safe > > > > On Wed, 2023-10-25 at 16:44 +0300, > > marius.cristea@xxxxxxxxxxxxx wrote: > > > From: Marius Cristea <marius.cristea@xxxxxxxxxxxxx> > > > > > > This is the iio driver for Microchip > > > PAC193X series of Power Monitor with Accumulator chip family. > > > > > > Signed-off-by: Marius Cristea <marius.cristea@xxxxxxxxxxxxx> > > > --- > > > > Hi Marius, > > > > I'll be honest and I just looked at this for 5min. But I'm seeing > > things like > > shunt resistors, vsense, power, energy... This seems to me that it > > belong to > > drivers/hwmon. Any special reason for IIO? > > > > Yes, this device is at the boundary between IIO and HWMON if you are > looking just at the "shunt resistors, vsense, power, energy". The > device also has ADC internaly that can measure voltages (up to 4 > channels) and also currents (up to 4 channels). Current is measured as > voltage across the shunt_resistor. > I think this alone is not justification but... > As I said before: I was thinking to start with a simple driver (this > one that is more apropiate to be a HWMON) and add more functionality > later (like data buffering that is quite important for example if > someone wants to profile power consumtion of the procesor itself, or a > pheriperic, or a battery, this kind of functionality was requested by > our customers). > having buffering support already makes a case for IIO, yes. Hmm, I'm also just realizing this is v2 and indeed you already justified the very same question in v1. Sorry for noise! - Nuno Sá >
