Hi Andy,
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> schrieb am Do, 19. Okt 19:54:
> On Thu, Oct 19, 2023 at 06:22:09PM +0200, Andreas Klinger wrote:
> > Only the bmp085 can have an End-Of-Conversion (EOC) interrupt. But the
> > bmp085 and bmp180 share the same chip id. Therefore it's necessary to
> > distinguish the case in which the interrupt is set.
> >
> > Fix the if statement so that only when the interrupt is set and the chip
> > id is recognized the interrupt is requested.
> >
> > This bug exists since the support of EOC interrupt was introduced.
>
> > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
>
> As Jonathan already commented, this is part of a tag block below...
>
> > Also add a link to bmp085 datasheet for reference.
> >
>
> ...somewhere here.
>
> > Suggested-by: Sergei Korolev <dssoftsk@xxxxxxxxx>
> > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx>
> > ---
> > v1 -> v2: Remove extra space (seen by Andy)
>
>
> And seems Jonathan mentioned that this is already fixed in his tree.
> Did I understand that correctly?
I just read it in the archive. For some reason I didn't get Jonathans mail
yesterday. Sorry for the spam.
Andreas
