On Sun, 15 Oct 2023 17:16:25 +0200
Angel Iglesias <ang.iglesiasg@xxxxxxxxx> wrote:
> Small cleanup reordering local variable declarations following reverse
> christmas tree convention.
>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index 6089f3f9d8f4..ea02a623bb58 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -766,8 +766,8 @@ static const struct iio_info bmp280_info = {
>
> static int bmp280_chip_config(struct bmp280_data *data)
> {
> - u8 osrs = FIELD_PREP(BMP280_OSRS_TEMP_MASK, data->oversampling_temp + 1) |
> - FIELD_PREP(BMP280_OSRS_PRESS_MASK, data->oversampling_press + 1);
> + u8 osrs = FIELD_PREP(BMP280_OSRS_PRESS_MASK, data->oversampling_press + 1) |
> + FIELD_PREP(BMP280_OSRS_TEMP_MASK, data->oversampling_temp + 1);
For fields within a register, don't bother.
Normally the order is dictated by someone reading the fields on a datasheet.
Feels like reorganzing them is just noise to me.
The rest look like good little tidy ups to me.
> int ret;
>
> ret = regmap_write_bits(data->regmap, BMP280_REG_CTRL_MEAS,
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c
> index b3e069730f97..34e3bc758493 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -7,9 +7,9 @@
>
> static int bmp280_i2c_probe(struct i2c_client *client)
> {
> - struct regmap *regmap;
> - const struct bmp280_chip_info *chip_info;
> const struct i2c_device_id *id = i2c_client_get_device_id(client);
> + const struct bmp280_chip_info *chip_info;
> + struct regmap *regmap;
>
> chip_info = i2c_get_match_data(client);
>
> diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c
> index 2eed483a8cc4..433d6fac83c4 100644
> --- a/drivers/iio/pressure/bmp280-spi.c
> +++ b/drivers/iio/pressure/bmp280-spi.c
> @@ -14,8 +14,7 @@
> static int bmp280_regmap_spi_write(void *context, const void *data,
> size_t count)
> {
> - struct device *dev = context;
> - struct spi_device *spi = to_spi_device(dev);
> + struct spi_device *spi = to_spi_device(context);
> u8 buf[2];
>
> memcpy(buf, data, 2);
> @@ -31,8 +30,7 @@ static int bmp280_regmap_spi_write(void *context, const void *data,
> static int bmp280_regmap_spi_read(void *context, const void *reg,
> size_t reg_size, void *val, size_t val_size)
> {
> - struct device *dev = context;
> - struct spi_device *spi = to_spi_device(dev);
> + struct spi_device *spi = to_spi_device(context);
>
> return spi_write_then_read(spi, reg, reg_size, val, val_size);
> }
