Re: [PATCH] IIO: hid-sensor-prox: add missing scale attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2023-10-14 at 17:52 +0100, Jonathan Cameron wrote:
> On Tue, 8 Aug 2023 14:22:10 +0200
> Philipp Jungkamp <p.jungkamp@xxxxxxx> wrote:
> 
> > > > The hid-sensor-prox returned an empty string on sysfs
> > > > in_proximity_scale
> > > > read. This is due to the the driver's scale never being
> > > > initialized.  
> > > 
> > > What is scale value reporting here? Is it 1.
> > > 
> > > Thanks,
> > > Srinivas  
> > 
> > Calling `read` on the sysfs file `in_proximity_scale` returns 0,
> > thus an empty string.
> > Adding the hid_format_scale call makes that a '1.000000'.
> > 
> > Regards,
> > Philipp
> 
> Srinivas - I was kind of waiting for a reply to say if you are happy
> with the explanation.
> All good?
All good.

Acked-by: Srinivas Pandruvada<srinivas.pandruvada@xxxxxxxxxxxxxxx>

> 
> Phillipp - this sounds like a fix to me.  Fixes tag?
> 
> Thanks,
> 
> Jonathan





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux