[AMD Official Use Only - General] Acked-by: O'Griofa, Conall <conall.ogriofa@xxxxxxx> Tested-by: O'Griofa, Conall <conall.ogriofa@xxxxxxx> Hi Jonathan, Thanks for the patches, changes look good, I have tested on board and not seen any issues from my testing. Cheers, Conall. > -----Original Message----- > From: Jonathan Cameron <jic23@xxxxxxxxxx> > Sent: Tuesday, October 10, 2023 5:19 PM > To: Simek, Michal <michal.simek@xxxxxxx> > Cc: Robert Hancock <robert.hancock@xxxxxxxxxx>; O'Griofa, Conall > <conall.ogriofa@xxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>; linux- > iio@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 0/2] Xilinx XADC fixes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On Sun, 24 Sep 2023 17:32:10 +0100 > Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > On Fri, 15 Sep 2023 08:52:49 +0200 > > Michal Simek <michal.simek@xxxxxxx> wrote: > > > > > +Conall > > > > > > On 9/15/23 02:10, Robert Hancock wrote: > > > > Fixes for a couple of issues in the Xilinx XADC driver: one where > > > > preconfigured temperature/voltage thresholds were being clobbered > > > > and potentially breaking overtemperature shutdown, and another for > > > > inaccurate temperature readings on UltraScale family devices. > > > > > > > > Changed since v2: Updated to also remove disabling XADC alarm bits. > > > > > > > > Robert Hancock (2): > > > > iio: adc: xilinx-xadc: Don't clobber preset voltage/temperature > > > > thresholds > > > > iio: adc: xilinx-xadc: Correct temperature offset/scale for > > > > UltraScale > > > > > > > > drivers/iio/adc/xilinx-xadc-core.c | 39 +++++++++++------------------- > > > > drivers/iio/adc/xilinx-xadc.h | 2 ++ > > > > 2 files changed, 16 insertions(+), 25 deletions(-) > > > > > > > > > > Conall: Please test and review. > > > > I'm sitting on this one until I hear back. No huge rush, but if you > > can estimate when you'll get to this I know to leave you alone until > > after that! > > I'll ask one more time, then probably just assume these are fine and apply. > > So Conall, have you had a chance to look at these? > > Thanks, > > Jonathan > > > > > Jonathan > > > > > > > > Thanks, > > > Michal > >
