On 08/10/2023 17:48, Subhajit Ghosh wrote: > Add devicetree bindings for Avago APDS9306 Ambient Light Sensor. > > Signed-off-by: Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> > --- > .../bindings/iio/light/avago,apds9306.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > new file mode 100644 > index 000000000000..e8bb897782fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/avago,apds9306.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Avago APDS9306 Ambient Light Sensor > + > +maintainers: > + - Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> > + > +description: > + Datasheet at https://docs.broadcom.com/doc/AV02-4755EN This is exactly the same as two other Avago devices. It should be squashed - first two device schemas squashed, then add new device support. Also, the supply is not vin, but vdd. Best regards, Krzysztof