On Tue, Oct 03, 2023 at 01:33:36PM +0300, Ceclan Dumitru-Ioan wrote: > On 9/30/23 17:05, Jonathan Cameron wrote: > > On Thu, 28 Sep 2023 15:54:43 +0300 > > Dumitru Ceclan <mitrutzceclan@xxxxxxxxx> wrote>> +config AD7173 > >> + tristate "Analog Devices AD7173 driver" > >> + depends on SPI_MASTER > >> + select AD_SIGMA_DELTA > >> + select GPIO_REGMAP > > If you are selecting it, why does it have if guards in the driver. > > I prefer the select here, so drop this if guards. > > From what i checked, selecting GPIO_REGMAP does not select GPIOLIB but only REGMAP. > > Also, in the thread from V1 Arnd Bergmann suggested: > " I think the best way to handle these is to remove both > the 'select' and the #ifdef in the driver and instead use > 'if (IS_ENABLED(CONFIG_GPIOLIB))' to handle optional gpio > providers in the code. " Why not simply to be dependent on GPIOLIB like other drivers do in this folder? -- With Best Regards, Andy Shevchenko
