> > - if (ret & AD2S1210_MSB_IS_HIGH) { > I guess this was meant to be a sanity check on the chip responding. > > > - ret = -EIO; > > - goto error_ret; > > - } > > - Yes, according to the data sheet, if this bit is set, it means there was a configuration parity error. This test has been moved to the ad2s1210_regmap_reg_read() function.