On Wed, 20 Sep 2023 20:53:33 +0530 Basavaraj Natikar <bnatikar@xxxxxxx> wrote: > On 9/20/2023 7:43 PM, Jiri Kosina wrote: > > On Tue, 19 Sep 2023, Basavaraj Natikar wrote: > > > >> This series adds support for light color temperature and chromaticity. > >> > >> v1->v2: > >> *Rename the series. > >> *Rename als_illum to als channel as it supports other channels. > >> *Update patch description to include same reading for the two existing > >> channels to use channel index to support more hub attributes. > >> *Keep line length under 80chars in hid-sensor-als. > >> *Add new channel type IIO_COLORTEMP. > >> *Update patch description and its subject to add channel type for > >> chromaticity. > >> > >> Basavaraj Natikar (9): > >> iio: hid-sensor-als: Use channel index to support more hub attributes > >> iio: Add channel type light color temperature > >> iio: hid-sensor-als: Add light color temperature support > >> HID: amd_sfh: Add support for light color temperature > >> HID: amd_sfh: Add support for SFH1.1 light color temperature > >> iio: Add channel type for chromaticity > >> iio: hid-sensor-als: Add light chromaticity support > >> HID: amd_sfh: Add light chromaticity support > >> HID: amd_sfh: Add light chromaticity for SFH1.1 > >> > >> Documentation/ABI/testing/sysfs-bus-iio | 15 ++ > >> .../hid_descriptor/amd_sfh_hid_desc.c | 7 + > >> .../hid_descriptor/amd_sfh_hid_desc.h | 3 + > >> .../hid_descriptor/amd_sfh_hid_report_desc.h | 21 +++ > >> drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 9 ++ > >> .../amd-sfh-hid/sfh1_1/amd_sfh_interface.h | 15 ++ > >> drivers/iio/industrialio-core.c | 2 + > >> drivers/iio/light/hid-sensor-als.c | 130 +++++++++++++++--- > >> include/linux/hid-sensor-ids.h | 4 + > >> include/uapi/linux/iio/types.h | 2 + > >> tools/iio/iio_event_monitor.c | 3 + > >> 11 files changed, 195 insertions(+), 16 deletions(-) > > I believe this should go through Jonathan's tree as a whole, right? > > Yes, this should go through Jonathan's tree as a whole. > If you don't have concerns, can you please ack HID amd_sfh changes? I'll do an immutable branch in case this needs pulling into the hid tree later in the cycle. In short that means I'll create a branch with just this series on top of v6.6-rc1 and push that out as ib-iio-hid-sensors-v6.6-rc1. I'll then merge that into the IIO tree before I do a pull request. The advantage of this being that it can be pulled into other trees as necessary and keep the same git IDs etc so that git can cleanly unwind the splitting and merging of the history to cover the different paths. However, note this will be messy as the merge into IIO isn't clean. I'll fix it up but please take a quick look at the testing branch of iio.git on kernel.org where the results of that merge will be. Some other channel types were added recently. So the fix was obvious. So applied to the branch ib-iio-hid-sensors-6.6-rc1. I'll merge that into the IIO tree. That will get pushed out as testing for the build bots to see if they can find anything we missed before I push this out as togreg which is what linux-next picks up. Note the IB branch might be rebased if any test issues show up. Thanks, Jonathan > > Thanks, > -- > Basavaraj >
