On Thu, Aug 24, 2023 at 1:54 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > Seems reasonable to me! I'd say I send a patch to the mailing list and see the response, I'm not very experienced with this device. The inputs of other people who worked on this driver would guide me in the right way then i guess. > That looks like the channel is actually processed, not raw, right? > i.e. that should only be done on channels marked as processed. Yeah the raw channel function does call a correction function in some cases, not very sure why. https://github.com/torvalds/linux/blob/master/drivers/iio/adc/twl6030-gpadc.c#L480 In the end the processed function also calls the raw function again dont know why, https://github.com/torvalds/linux/blob/master/drivers/iio/adc/twl6030-gpadc.c#L496. But in any case there is no mention of the scale attribute, so to make it comply with the condition I dont see an issue adding it to the properties Regards, Mithil
