On Thu, 31 Aug 2023 20:25:02 +0200
Marek Vasut <marex@xxxxxxx> wrote:
> The comparator generates an edge on the IRQ like and stays in the
> configured state until cleared. Support edge triggered IRQs as well
> as not all controllers do support level triggered IRQ.
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
Hi Marek,
Seems safe enough change given the latch is enabled.
I guess it's not really a fix, but I'd be fine with a request
for this to be added to stable if you like.
Applied to the togreg branch of iio.git and pushed out as testing
only until I can rebase on rc1.
Thanks,
Jonathan
> ---
> Cc: "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx
> ---
> drivers/iio/adc/ti-ads1015.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index 075c75a875449..addee45ed40ad 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -1047,11 +1047,13 @@ static int ads1015_probe(struct i2c_client *client)
> 1 << ADS1015_CFG_COMP_LAT_SHIFT;
>
> switch (irq_trig) {
> + case IRQF_TRIGGER_FALLING:
> case IRQF_TRIGGER_LOW:
> cfg_comp |= ADS1015_CFG_COMP_POL_LOW <<
> ADS1015_CFG_COMP_POL_SHIFT;
> break;
> case IRQF_TRIGGER_HIGH:
> + case IRQF_TRIGGER_RISING:
> cfg_comp |= ADS1015_CFG_COMP_POL_HIGH <<
> ADS1015_CFG_COMP_POL_SHIFT;
> break;
