On Thu, 2023-08-31 at 10:28 +0100, Jonathan Cameron wrote: > On Thu, 31 Aug 2023 10:20:20 +0200 > Nuno Sá <noname.nuno@xxxxxxxxx> wrote: > > > On Wed, 2023-08-30 at 17:29 +0100, Jonathan Cameron wrote: > > > On Fri, 4 Aug 2023 16:53:38 +0200 > > > Nuno Sa <nuno.sa@xxxxxxxxxx> wrote: > > > > > > > This is the initial RFC following the discussion in [1]. I'm aware this is > > > > by no means ready for inclusion and it's not even compilable since in > > > > the RFC I did not included the patch to add component_compare_fwnode() > > > > and component_release_fwnode(). > > > > > > Whilst I haven't read this through yet, I suspect Olivier will be able to > > > offer some insight on some of this and likewise you may be able to > > > point out pitfalls etc in his series (I see you did some review already :) > > > > > > https://lore.kernel.org/linux-iio/20230727150324.1157933-1-olivier.moysan@xxxxxxxxxxx/ > > > > > > Both are about multiple interacting components of an overall datapath. > > > Whether there is commonality isn't yet clear to me. > > > > > > > I made a very general comment in that series but I need to look better at it. Not > > sure if we can merge them together but let's see... > > Great. I wasn't sure either! If nothing else more cross review is always > good even if we decide we need two frameworks. > Indeed... > My one takeaway from looking at this is I need to understand the component > framework better and do some messing around with simple cases before I'll Fair enough... It's a fairly straight framework and I like the idea of having the whole thing (multiple devices) coming up/down together since it simplifies some things. But I don't feel to strong about it so in the end, if we decide to go with typical OF/FW lookup, also fine with me. > be confident on how this works. Maybe we can get some input from developers > of that framework on future versions? > Sure, they might have some thoughts on the hacks I'm doing to use devres. But I fear they'll be a bit biased for what they "enforce" in the component framework (my idea was to build on top of it). - Nuno Sá