Re: [PATCH v2] dt-bindings: iio: adc: Add TI TWL603X GPADC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 20 Aug 2023 22:34:33 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:

> On 20/08/2023 14:32, Andreas Kemnade wrote:
> > Document TI TWL603X GPADC devicetree bindings.
> > A driver is already there, the compatibles are used, but not documented.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > ---  
> 
> Please provide changelog after ---.
> 
> 
> >  .../bindings/iio/adc/ti,twl6030-gpadc.yaml    | 45 +++++++++++++++++++
> >  1 file changed, 45 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml b/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml
> > new file mode 100644
> > index 000000000000..5b075237bcfd
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/ti,twl6030-gpadc.yaml
> > @@ -0,0 +1,45 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/ti,twl6030-gpadc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: GPADC subsystem in the TWL6030 power module
> > +
> > +maintainers:
> > +  - Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > +
> > +description:
> > +  The GPADC subsystem in the TWL603X consists of a 10-bit ADC
> > +  combined with a 15-input analog multiplexer in the TWL6030 resp. a
> > +  19-input analog muliplexer in the TWL6032.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ti,twl6030-gpadc
> > +      - ti,twl6032-gpadc
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  "#io-channel-cells":
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - interrupts
> > +  - "#io-channel-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    twl {  
> 
> Just skip the twl node. Anyway, the parent device binding should include
> complete example.
I tidied that up whilst applying.
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to poke at it.  I'll be rebasing once rc1 is out so until then I won't
push this out as a branch linux-next will pick up.

Thanks,

Jonathan

> 
> Best regards,
> Krzysztof
> 




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux