On 24/08/2023 18:55, Liam Beguin wrote: > Add devicetree bindings for the Linear Technology LTC2309 ADC driver. > > Signed-off-by: Liam Beguin <liambeguin@xxxxxxxxx> Thank you for your patch. There is something to discuss/improve. > +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2309.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: GPL-2.0 Wrong license. Run checkpatch before sending patches. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/lltc,ltc2309.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Linear Technology / Analog Devices LTC2309 ADC > + > +maintainers: > + - Liam Beguin <liambeguin@xxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - lltc,ltc2309 > + > + refcomp-supply: > + description: Power supply for the reference voltage refcomp is not a supply. It is called "Reference Buffer Output.". You probably wanted vref-supply, which suggests you should just add it to ltc2497 bindings. I don't see any differences. > + > + reg: > + enum: > + - 0x08 > + - 0x09 > + - 0x0a > + - 0x0b > + - 0x18 > + - 0x19 > + - 0x1a > + - 0x1b > + - 0x28 > + > + "#io-channel-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@28 { > + #io-channel-cells = <1>; > + compatible = "lltc,ltc2309"; > + reg = <0x28>; If the example stays, then order is compatible first, then reg, then the rest. Also add the supply to make example complete. But I think this should be squashed with other binding so no need for the example. Best regards, Krzysztof
