On Wed, Aug 23, 2023 at 07:10:33PM +0300, Andy Shevchenko wrote:
> On Wed, Aug 23, 2023 at 05:58:05PM +0200, Angel Iglesias wrote:
> > Represent the device id reg values using uint8 to optimize memory use.
>
> This doesn't correspond to the code, in the code you used uint8_t.
...
> > struct bmp280_chip_info {
> > unsigned int id_reg;
> > - const unsigned int chip_id;
> > + uint8_t chip_id;
>
> While this will compile and even work properly in kernel we use uXX types,
> here u8.
Actually this patch doesn't optimize memory use. The alignment will create
a gap anyway.
That said, this patch is simply redundant.
--
With Best Regards,
Andy Shevchenko
