Re: [PATCH v3 2/2] iio: adc: adding support for MCP3564 ADC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan,

> 
> > @@ -0,0 +1,53 @@
> > +What:               
> > /sys/bus/iio/devices/iio:deviceX/boost_current
> > +KernelVersion:       6.4
> > +Contact:     linux-iio@xxxxxxxxxxxxxxx
> > +Description:
> > +             This attribute is used to set the biasing circuit of
> > the
> > +             Delta-Sigma modulator. The different BOOST settings
> > are applied
> > +             to the entire modulator circuit, including the
> > voltage reference
> > +             buffers.
> 
> Units?  Should be  mA given that is what we use for other current
> attributes
> in IIO.
> 

This should have no units because is a "gain" for the bias current. I
think it will be better to change the name of the attribute to
"boost_current_gain".


> This one may cause us problems with generality of the description if
> we reuse
> if for other devices (and hence move it to the more general files),
> but we
> can figure this out at the time.
> 
> > 

Thanks and Best Regards,
Marius





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux