Hi Marek Vasut, Thanks for the feedback. > Subject: Re: [PATCH 1/2] iio: dac: mcp4725: Replace variable 'id' from > struct mcp4725_data > > On 8/12/23 13:54, Biju Das wrote: > > Replace the variable 'id' from struct mcp4725_data with local variable > > chip_id in probe(). > > ... because the id variable is not used elsewhere in the driver ? > > It probably makes sense to add the reasoning into the commit message. I thought it is understood from commit message. Ie, you are moving it from global to local, Jonathan, is it something you can do while applying, if it make sense? Cheers, Biju
