On Wed, Aug 09, 2023 at 08:14:54PM +0200, Krzysztof Kozlowski wrote: > On 09/08/2023 20:02, Jonathan Cameron wrote: > > On Wed, 9 Aug 2023 08:41:05 +0200 > > Marcus Folkesson <marcus.folkesson@xxxxxxxxx> wrote: ... > >>> Inconsistent macro implementation, i.e. you need to use (x). > >> > >> Sorry, I do not get you In other macros you avoid ambiguity of the parameter, so they can be evaluated properly, and not here. ... > >>>> + if (device_property_read_bool(&adc->spi->dev, "microchip,data-ready-hiz")) (1) > >>> This also becomes shorter. > >>> > >>> One trick to make it even shorter: > >>> > >>> if (device_property_present(dev, "microchip,data-ready-hiz")) > >> > >> Thank you, I wasn't aware of device_property_present(). > > > > I know the read_bool function is direct equivalent of this but where a property > > is a flag, it feels more natural to me to check it with that one. > > read_present() feels more appropriate for where you want to know a more > > complex property is present. > > > > Doesn't matter that much either way however so up to you. > > For the OF, of_property_read_bool() is indeed preferred. Is there > device-xxx() equivalent? See (1) above ? -- With Best Regards, Andy Shevchenko
