On Mon, Aug 07, 2023 at 09:18:31AM +0200, Marcus Folkesson wrote:
> Microchip does have many similar chips, add support for those.
>
> The new supported chips are:
> - microchip,mcp3910
> - microchip,mcp3912
> - microchip,mcp3913
> - microchip,mcp3914
> - microchip,mcp3918
> - microchip,mcp3919
...
> +#define MCP3910_STATUSCOM_DRHIZ BIT(20)
Is it deliberately using spaces? If so, why?
...
> +static int mcp3910_get_osr(struct mcp3911 *adc, int *val)
> +{
> + int ret, osr;
> +
> + ret = mcp3911_read(adc, MCP3910_REG_CONFIG0, val, 3);
> + osr = FIELD_GET(MCP3910_CONFIG0_OSR, *val);
> + *val = 32 << osr;
> + return ret;
I believe this is wrong order. Or bad code. The rule of thumb is not pollute
the output variable if we know the error happened.
Same applies to another function.
> +}
...
> - ret = mcp3911_config(adc);
> + ret = device_property_read_u32(&adc->spi->dev, "microchip,device-addr", &adc->dev_addr);
Why not spi->dev? Ditto for other uses like this.
--
With Best Regards,
Andy Shevchenko
