RE: [PATCH v6 3/4] i2c: Enhance i2c_get_match_data()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy Shevchenko,

Thanks for the feedback.

> Subject: Re: [PATCH v6 3/4] i2c: Enhance i2c_get_match_data()
> 
> On Fri, Aug 04, 2023 at 08:09:14AM +0100, Biju Das wrote:
> > Enhance i2c_get_match_data() for a faster path for device_get_
> > match_data().
> 
> Strange wrap, the function name shouldn't have a new line in between :-)

OK. Wrapping is not required, as it is fitting to chars

scripts/checkpatch.pl --strict 0002-i2c-Enhance-i2c_get_match_data.patch 
total: 0 errors, 0 warnings, 0 checks, 27 lines checked

0002-i2c-Enhance-i2c_get_match_data.patch has no obvious style problems and is ready for submission.

> 
> > While at it, add const to struct i2c_driver to prevent overriding the
> > driver pointer.
> 
> ...
> 
> > v6:
> >  * Separate patch to prepare for better difference for
> >    i2c_match_id() changes.
> 
> With this it actually should be patch 2 and patch 2 become 3 (there is not
> much difference code wise, but logically this  can be applied even without
> the rest).

OK will move to patch#2.

Cheers,
Biju

> 
> With the above addressed
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> --
> With Best Regards,
> Andy Shevchenko
> 





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux