Hi Biju, Thanks for your patch! On Fri, Jul 21, 2023 at 5:39 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > All functions except rz_mtu3_count_enable_write(), calls call > pm_runtime_{get,put} inside the lock. For consistency do the same here. > > Reported-by: Pavel Machek <pavel@xxxxxxx> > Closes: https://patchwork.kernel.org/project/cip-dev/patch/20230606075235.183132-6-biju.das.jz@xxxxxxxxxxxxxx/ This is not a direct link to Pavel's report, but to the bread started by your patch. Why not a link to lore? Closes: https://lore.kernel.org/r/ZH8Fmom8vZ4DwxqA@xxxxxxxxxx > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- > v1->v2: > * Updated commit header to make it clear this is not addressing a bug, > rather it's just cleanup. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds