On Sun, Jul 23, 2023 at 10:23:35AM +0100, Jonathan Cameron wrote: > On Fri, 21 Jul 2023 20:00:21 +0300 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > Move subsys_initcall() and module_exit() closer to the respective calls. > > Why? For this particular set of macros I can see advantages to them being > near the code and to them being in a fairly predictable location (end of > file). > > I think the patch description should make the why argument. The documented case is about exported symbols. Now I looked for the module_*() stuff and there is no consensus between subsystems. Both styles are being documented and used. I think I may drop this. Someone also can investigate the trends, but I won't spend my time on this. Thank you for the review. -- With Best Regards, Andy Shevchenko
