On Fri, 7 Jul 2023 18:27:37 +0300 George Stark <gnstark@xxxxxxxxxxxxxx> wrote: > From: George Stark <GNStark@xxxxxxxxxxxxxx> All looks fine to me. However, given earlier versions had various other reviewers I'd like to leave it on list a little longer. Jonathan > > Changelog: > > v1->v2: > split refactoring patch [1] into 4 smaller patches, fix comment style > > [1] https://lore.kernel.org/lkml/20230621062715.455652-2-gnstark@xxxxxxxxxxxxxx/ > > v2->v3: > remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion > > patch 'meson saradc: add enum for iio channel array indexes' > - change enum items prefix from INDEX_ to NUM_ since name 'channel index' is > more relevant to channel array index in iio world and with 2 tables our array index is > not always equal to channel number > - resolve conflicts after deleting [1] > - update commit message, previous patch [2] > - return channel number for temp channel. It wasn't used and isn't used currently > but may need later > > patch meson saradc: support reading from channel 7 mux inputs > - resolve conflicts after deleting [1] > - update commit message, previous patch [3] > - add routine find_channel_by_num to get channel by channel number > > [1] https://lore.kernel.org/lkml/20230623022334.791026-4-gnstark@xxxxxxxxxxxxxx/ > [2] https://lore.kernel.org/lkml/20230623022334.791026-5-gnstark@xxxxxxxxxxxxxx/ > [3] https://lore.kernel.org/lkml/20230623022334.791026-7-gnstark@xxxxxxxxxxxxxx/ > > v3->v4: > add new patch 'iio: adc: meson: remove unused timestamp channel' [1] > > patch 'iio: adc: meson: move enums declaration before' > update commit message, previous patch [2] > patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux' > update commit message, previous patch [3] > patch 'iio: adc: meson: add enum for iio channel numbers' > update commit message, previous patch [4] > patch 'iio: adc: meson: add channel labels' > update commit message, previous patch [5] > change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n") > patch 'iio: adc: meson: support reading from channel 7 mux' > rewrite enum meson_sar_adc_chan7_mux_sel definition and > read_label routine proposed by Andy [7], previous patch [6] > > [1] https://lore.kernel.org/lkml/20230705160413.000062e7@xxxxxxxxxx/ > [2] https://lore.kernel.org/lkml/20230627224017.1724097-2-gnstark@xxxxxxxxxxxxxx/ > [3] https://lore.kernel.org/lkml/20230627224017.1724097-3-gnstark@xxxxxxxxxxxxxx/ > [4] https://lore.kernel.org/lkml/20230627224017.1724097-4-gnstark@xxxxxxxxxxxxxx/ > [5] https://lore.kernel.org/lkml/20230627224017.1724097-5-gnstark@xxxxxxxxxxxxxx/ > [6] https://lore.kernel.org/lkml/20230627224017.1724097-6-gnstark@xxxxxxxxxxxxxx/ > [7] https://lore.kernel.org/lkml/ZJwGCNA+ZURri24i@xxxxxxxxxxxxxxxxxx/ > > George Stark (6): > iio: adc: meson: remove unused timestamp channel > iio: adc: meson: move enums declaration before variables declaration > iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper > iio: adc: meson: add enum for iio channel numbers > iio: adc: meson: add channel labels > iio: adc: meson: support reading from channel 7 mux inputs > > drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++-------- > 1 file changed, 134 insertions(+), 39 deletions(-) >
