On 6/17/23 22:57, Jonathan Cameron wrote:
On Tue, 13 Jun 2023 13:20:26 +0300 Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:The ROHM BU27010 is an RGBC sensor with a flickering detection FIFO. The RGBC+IR sensor functionality is largely similar to what the BU27008 has. There are some notable things though: - gain setting is once again new and exotic. Now, there is 6bit gain setting where 4 of the bits are common to all channels and 2 bits can be configured separately for each channel. The BU27010 has similar "1X on other channels vs 2X on IR when selector is 0x0" gain design as BU27008 had. So, we use same gain setting policy for BU27010 as we did for BU27008 - driver sets same gain selector for all channels but shows the gains separately for all channels so users can (at least in theory) detect this 1X vs 2X madness... - BU27010 has suffled all the control register bitfields to new addresses and bit positions while still keeping the register naming same. - Some more power/reset control is added. - FIFO for "flickering detection" is added. The control register suffling made this slightly nasty. Still, it is easier for maintenance perspective to add the BU27010 support in BU27008 driver because - even though the bit positions/addresses were changed - most of the driver structure can be re-used. Writing own driver for BU27010 would mean plenty of duplicate code albeit a tad more clarity. The flickering FIFO is not supported by the driver. Add BU27010 RGBC+IR support to rohm-bu27008 driver. Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>Resulting code looks more or less fine, but there is stuff in here that belongs in previous patch - so send a v2 with the refactors all done there and just support for the new part in here.
Thanks for the review! I appreciate it. And sorry for sending a messy version. I'll try re-organizing the stuff between these two patches when re-spinning. A bit busy now as I said when replying to review of PATCH 2/3 - but I'll see when I get a moment to rework this :) Thanks!
Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~
