On Mon, 12 Jun 2023 13:15:44 +0300 <andy.shevchenko@xxxxxxxxx> wrote: > Mon, Jun 12, 2023 at 10:08:47AM +0200, Markus Burri kirjoitti: > > After calibration the indio_dev is used to get channel information. > > Since the pointer is not stored into spi driver data, there is a kernel > > null pointer dereference. > > Store the indio_dev into spi driver data to fix this. > > This definitely deserves the Fixes tag. Can you dig the history to find the > culprit one? Good catch, but see https://lore.kernel.org/all/20230530075311.400686-2-fl.scratchpad@xxxxxxxxx/ Which I think is a nicer fix for the same issue. I sent a pull request for that fix yesterday, but given we are late in the cycle it might go in during the merge window then get backported to stable kernels after that. > > > Add error check and slightly extend the debug messages. > > I'm not sure this will belong to the same change, so I would split this out to > a separate one. Definitely. Multiple issues so multiple patches. Thanks, Jonathan >
