Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 11 Jun 2023, srinivas pandruvada wrote:

> > > The Lenovo Yoga C630 has a combined keyboard and accelerometer that 
> > > interfaces via i2c-hid. Currently this laptop either has a working 
> > > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working 
> > > accelerometer. only works on kernels. Put another way, most distro 
> > > kernels enable CONFIG_HID_SENSOR_HUB and therefore cannot work on 
> > > this device since the keyboard doesn't work!
> > > 
> > > Fix this by providing a richer connect mask during the probe. With 
> > > this change both keyboard and screen orientation sensors work 
> > > correctly.
> > > 
> > > Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > 
> > Srinivas, are you aware of any multi-function device that this patch 
> > might break?
> I tried two systems, one with ISH and another with external hub. Didn't 
> break anything. I don't have 5+ years old systems, to confirm if it will 
> break something on older systems with external hub.

Thanks a lot. Can I take the above as an equivalent of

	Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>

? :)

-- 
Jiri Kosina
SUSE Labs




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux