On Mon, 29 May 2023 12:02:16 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, May 29, 2023 at 10:41 AM Astrid Rost <astridr@xxxxxxxx> wrote:
> > Thanks for reviewing.
> > I can change this. But this is how it gets formatted by .clang-format.
>
> I would suggest to report the bug (in case it's not configurable) or
> configure to avoid such a misindentation.
I assume it's trading off line length against aligning with opening brackets.
Maybe made the wrong decision, but it is not totally unreasonable to my eyes.
I don't care either way though, so go with whatever you have for next version!
Jonathan
>
> > On 5/29/23 00:45, andy.shevchenko@xxxxxxxxx wrote:
> > > Mon, May 22, 2023 at 04:26:18PM +0200, Astrid Rost kirjoitti:
> > >> Add support to configure ambient light sensor interrupts and threshold
> > >> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
> > >> will be pushed to the event interface.
> > >
> > > ...
> > >
> > >> + case IIO_EV_DIR_RISING:
> > >> + ret = i2c_smbus_write_word_data(
> > >> + data->client, VCNL4040_ALS_THDH_LM, val);
> > >
> > > Strange indentation.
> > >
> > >> + break;
> > >> + case IIO_EV_DIR_FALLING:
> > >> + ret = i2c_smbus_write_word_data(
> > >> + data->client, VCNL4040_ALS_THDL_LM, val);
> > >
> > > Same.
> > >
> > >> + break;
> > >
> > > ...
> > >
> > >> + case IIO_PROXIMITY:
> > >> + switch (dir) {
> > >> + case IIO_EV_DIR_RISING:
> > >> + ret = i2c_smbus_write_word_data(
> > >> + data->client, VCNL4040_PS_THDH_LM, val);
> > >
> > > Same.
> > >
> > >> + break;
> > >> + case IIO_EV_DIR_FALLING:
> > >> + ret = i2c_smbus_write_word_data(
> > >> + data->client, VCNL4040_PS_THDL_LM, val);
> > >
> > > Same.
>
