Re: [PATCH v3 2/8] iio: adc: rockchip_saradc: Add support for RK3588

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/06/23 15:50, Jonathan Cameron wrote:
On Sat, 3 Jun 2023 23:48:00 +0300
andy.shevchenko@xxxxxxxxx wrote:

Sun, Jun 04, 2023 at 12:23:34AM +0530, Shreeya Patel kirjoitti:
From: Simon Xue <xxm@xxxxxxxxxxxxxx>

Add new start and read functions to support rk3588 device.
Also, add a device compatible string for the same.
...

+/* v2 registers */
+#define SARADC2_CONV_CON		0x0
+#define SARADC_T_PD_SOC			0x4
+#define SARADC_T_DAS_SOC		0xc
Can you use fixed-width values for all registers?

	0x000
	0x004
	0x00c

+#define SARADC2_END_INT_EN		0x104
+#define SARADC2_ST_CON			0x108
+#define SARADC2_STATUS			0x10c
+#define SARADC2_END_INT_ST		0x110
+#define SARADC2_DATA_BASE		0x120
I tidied this up whilst applying.

 Ah, I was just about to send a v4 with the change. Thank you for making the changes.


Regards,
Shreeya Patel


Jonathan



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux