Tue, May 30, 2023 at 04:24:02PM +0200, Astrid Rost kirjoitti:
> Add support to configure ambient light sensor interrupts and threshold
> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
> will be pushed to the event interface.
...
> - int ret;
> + int ret = -EINVAL;
What is the purpose of this change?
...
> - int ret;
> + int ret = -EINVAL;
Ditto.
...
> int ret;
> struct vcnl4000_data *data = iio_priv(indio_dev);
> + switch (chan->type) {
Had you run checkpatch.pl? A definition block and a code should be delimited
by a blank line.
...
> - int ret;
> + int ret = -EINVAL;
Purpose?
...
> - val = state ? (ret | mask) : (ret & ~mask);
> + val = state ? (ret | mask) : (ret & ~mask);
I'm wondering if you can prepere the code by introducing switch-case instead of
current implementation in the preparatory patch and then do what you want to do
here. It will show much better the change and make review easier.
--
With Best Regards,
Andy Shevchenko
