Wed, May 31, 2023 at 02:25:11PM +0000, inv.git-commit@xxxxxxx kirjoitti: > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@xxxxxxx> > > Create new inv_sensors common modules and move inv_icm42600 > timestamp module inside. > Modify inv_icm42600 driver to use timestamp module. ... > #include <linux/kernel.h> > #include <linux/math64.h> > +#include <linux/module.h> > #include <linux/errno.h> > - Leave this blank line. It helps to divide generic headers and IIO (subsystem) related. > -#include "inv_icm42600_timestamp.h" > +#include <linux/iio/common/inv_icm42600_timestamp.h> ... > #include <linux/delay.h> + Blank line? > #include <linux/iio/iio.h> Keep it ordered? (But yeah, this one probably out of scope of the series.) > #include <linux/iio/buffer.h> > +#include <linux/iio/common/inv_icm42600_timestamp.h> > #include "inv_icm42600.h" > -#include "inv_icm42600_timestamp.h" > #include "inv_icm42600_buffer.h" ... > #include <linux/property.h> > #include <linux/regmap.h> + Blank line? > #include <linux/iio/iio.h> > +#include <linux/iio/common/inv_icm42600_timestamp.h> Keep it ordered? > > #include "inv_icm42600.h" > #include "inv_icm42600_buffer.h" > -#include "inv_icm42600_timestamp.h" ... > #include <linux/math64.h> > #include <linux/iio/iio.h> > #include <linux/iio/buffer.h> > +#include <linux/iio/common/inv_icm42600_timestamp.h> > #include <linux/iio/kfifo_buf.h> > > #include "inv_icm42600.h" > #include "inv_icm42600_temp.h" > #include "inv_icm42600_buffer.h" > -#include "inv_icm42600_timestamp.h" As per above comments. -- With Best Regards, Andy Shevchenko
