On Mon, 22 May 2023 08:15:01 +0300
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
> Hi Andy,
>
> On 5/21/23 20:19, andy.shevchenko@xxxxxxxxx wrote:
> > Fri, May 19, 2023 at 02:01:47PM +0300, Matti Vaittinen kirjoitti:
> >> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> >>
> >> Drop check for return value 0.
> >
> > ...
> >
> >> - if (v->irq <= 0) {
> >> + if (v->irq < 0) {
> >> ret = -EINVAL;
> >
> > ret = v->irq;
> >
> > ?
>
> For me that seems to be correct, yes. This, however, would be a
> functional change and in my opinion it should be done separately from
> this API change.
Ah. I commented on this as well in v6. Roll us that separate patch
and I expect we'll both be happy ;)
Jonathan
>
> >
> >> goto err;
> >> }
> >
>
