Re: [PATCH v6 6/8] pinctrl: pistachio: relax return value check for IRQ get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 26 May 2023 09:38:58 +0300
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:

> fwnode_irq_get[_byname]() were changed to not return 0 anymore.
> 
> Drop check for return value 0.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> ---
> Revision history:
>  - No changes
> 
> Please note, I took Linus' reply to v4 cover-letter as ack && added the
> tag. Please let me know if this was not Ok.

Whilst I understand your point as Linus said he'd pick the patches up,
I would have left it to Linus to Ack explicitly but added a note here
to say he basically already did.

LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> 
> The first patch of the series changes the fwnode_irq_get() so this depends
> on the first patch of the series and should not be applied alone.
> ---
>  drivers/pinctrl/pinctrl-pistachio.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
> index 53408344927a..8c50e0091b32 100644
> --- a/drivers/pinctrl/pinctrl-pistachio.c
> +++ b/drivers/pinctrl/pinctrl-pistachio.c
> @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
>  			dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i);
>  			goto err;
>  		}
> -		if (!ret) {
> -			fwnode_handle_put(child);
> -			dev_err(pctl->dev, "No IRQ for bank %u\n", i);
> -			ret = -EINVAL;
> -			goto err;
> -		}
>  		irq = ret;
>  
>  		bank = &pctl->gpio_banks[i];




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux