On Tue, May 16, 2023 at 10:12:41AM +0300, Matti Vaittinen wrote: > fwnode_irq_get() was changed to not return 0 anymore. > > Drop check for return value 0. ... > - if (data->irqnr <= 0) { > + if (data->irqnr < 0) { > /* usage of interrupt is optional */ > data->irqnr = -1; > } else { After this change I'm not sure we need this branch at all, I mean that -errn is equal to -1 in the code (but needs to be checked for silly checks like == -1). Hence Entire excerpt can be replaced with if (data->irqnr > 0) { -- With Best Regards, Andy Shevchenko