On Mon, May 15, 2023 at 12:33:06AM +0530, Anup Sharma wrote: > Adds an of_device_id table entry to the driver, enabling > device matching through device tree. With this update, the driver > can now match devices using both the i2c_device_id entry and the > newly added of_device_id table. ... > #include <linux/module.h> > #include <linux/pm.h> > #include <linux/bitops.h> > +#include <linux/mod_devicetable.h> Can you try to keep this ordered as much as possible? (For example, by locating a new inclusion near to module.h) ... > +static const struct of_device_id tmp006_of_match[] = { > + { .compatible = "ti,tmp006", }, Inner comma is not needed. > + { } > +}; -- With Best Regards, Andy Shevchenko