Re: [PATCH] iio: dac: mcp4725: Fix i2c_master_send() return value handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 11, 2023 at 02:43:30AM +0200, Marek Vasut wrote:
> The i2c_master_send() returns number of sent bytes on success,
> or negative on error. The suspend/resume callbacks expect zero
> on success and non-zero on error. Adapt the return value of the
> i2c_master_send() to the expectation of the suspend and resume
> callbacks, including proper validation of the return value.
> 
> Fixes: cf35ad61aca2 ("iio: add mcp4725 I2C DAC driver")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>

Makes sense,

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux