Hi Matti, On Fri, Apr 21, 2023 at 09:14:10AM +0300, Matti Vaittinen wrote: > Hi Mehdi, > > Thanks for the v2! > > On 4/20/23 23:22, Mehdi Djait wrote: > > Since Kionix accelerometers use various numbers of bits to report data, a > > device-specific function is required. > > I think this is the right approach. Thanks for adding this device-specific > function. > > > Move the driver's private data to the header file to support the new function. > > Hmm. Why this move is necessary? I didn't immediately spot this struct being > used outside this C-file. I'd rather saw the struct in C-file if possible. My bad, I will move it back -- Kind Regards Mehdi Djait
