Hi Krzysztof,
On Fri, 21 Apr 2023 09:32:57 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> On 20/04/2023 14:13, Herve Codina wrote:
> > The Renesas X9250 is a quad digitally controlled potentiometers.
> >
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +maintainers:
> > + - Herve Codina <herve.codina@xxxxxxxxxxx>
> > +
> > +description:
> > + The Renesas X9250 integrates four digitally controlled potentiometers.
> > + On each potentiometer, the X9250T has a 100 kOhms total resistance and the
> > + X9250U has a 50 kOhms total resistance.
> > +
> > +allOf:
> > + - $ref: /schemas/spi/spi-peripheral-props.yaml
> > + - $ref: /schemas/iio/iio.yaml
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - renesas,x9250t
> > + - renesas,x9250u
> > +
> > + reg:
> > + description:
> > + SPI device address.
>
> SPI bus does not have device addresses, AFAIR. Drop description.
Indeed, SPI has chip-select.
I will drop the description
>
> > + maxItems: 1
> > +
> > + '#io-channel-cells':
> > + const: 1
> > +
> > + spi-max-frequency:
> > + maximum: 2000000
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#io-channel-cells'
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + x9250@0 {
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Will be change to potentiometer@0
>
> > + compatible = "renesas,x9250t";
> > + reg = <0>;
> > + spi-max-frequency = <2000000>;
> > + #io-channel-cells = <1>;
> > + };
> > + };
>
> Best regards,
> Krzysztof
>
The modifications will be present on v3 as v2 was already sent.
Thanks for the review,
Hervé
