On 18/04/2023 12:36, Stefan Windfeldt-Prytz wrote: > Add devicetree bindings for opt4001 ambient light sensor. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@xxxxxxxx> > --- > .../devicetree/bindings/iio/light/ti,opt4001.yaml | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml > new file mode 100644 > index 000000000000..43fd1a992aea > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/ti,opt4001.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/ti,opt4001.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments OPT4001 Ambient Light Sensor > + > +maintainers: > + - Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@xxxxxxxx> > + > +description: | Do not need '|' unless you need to preserve formatting. > + Ambient light sensor with an i2c interface. > + Last part of compatible is for the packaging used. > + Picostar is a 4 pinned SMT and sot-5x3 is a 8 pinned SOT. > + Only sot-5x3 has an interrupt pin. Drop this sentence. It obvious from the schema. > + https://www.ti.com/lit/gpn/opt4001 > + > +properties: > + compatible: > + enum: > + - ti,opt4001-picostar > + - ti,opt4001-sot-5x3 Best regards, Krzysztof
