On Mon, 3 Apr 2023 21:14:55 -0400 Brian Masney <bmasney@xxxxxxxxxx> wrote: > tsl2772_read_prox_diodes() will correctly parse the properties from > device tree to determine which proximity diode(s) to read from, however > it didn't actually set this value on the struct tsl2772_settings. Let's > go ahead and fix that. > > Reported-by: Tom Rix <trix@xxxxxxxxxx> > Link: https://lore.kernel.org/lkml/20230327120823.1369700-1-trix@xxxxxxxxxx/ > Fixes: 94cd1113aaa0 ("iio: tsl2772: add support for reading proximity led settings from device tree") > Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx> Applied to the fixes-togreg branch of iio.git and marked for stable. thanks, Jonathan > --- > drivers/iio/light/tsl2772.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c > index ad50baa0202c..e823c145f679 100644 > --- a/drivers/iio/light/tsl2772.c > +++ b/drivers/iio/light/tsl2772.c > @@ -601,6 +601,7 @@ static int tsl2772_read_prox_diodes(struct tsl2772_chip *chip) > return -EINVAL; > } > } > + chip->settings.prox_diode = prox_diode_mask; > > return 0; > }
