On 3/20/23 14:34, Jonathan Cameron wrote:
On Mon, 20 Mar 2023 11:35:06 +0200
Matti Vaittinen <mazziesaccount@xxxxxxxxx> wrote:
On 3/17/23 01:48, Mehdi Djait wrote:
OTOH, to really benefit from this we should probably pull out the
regmap-configs from the kionix-kx022a.c. I am not really sure where we
should put it then though. Hence, if there is no good ideas how to split
the config and chip-info so they are only available/used where needed -
then I am also Ok with the current approach.
Definitely stick to current approach. If I had the time I'd
rip out all the code useing enums in match tables. It's bitten us
a few times with nasty to track down bugs that only affect more obscure
ways of binding the driver.
Seems like Jonathan has a strong opinion on this. Please follow his and
Andy's guidance on this one and forget my comment.
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
