On Tue, 2023-03-14 at 00:07 +0100, Andi Shyti wrote: > Hi Todd, > > On Mon, Mar 13, 2023 at 03:06:53PM -0700, Todd Brandt wrote: > > On some platforms there are some platform devices created with > > invalid names. For example: "HID-SENSOR-INT-020b?.39.auto" instead > > of "HID-SENSOR-INT-020b.39.auto" > > > > This string include some invalid characters, hence it will fail to > > properly load the driver which will handle this custom sensor. Also > > it is a problem for some user space tools, which parse the device > > names from ftrace and dmesg. > > > > This is because the string, real_usage, is not NULL terminated and > > printed with %s to form device name. > > > > To address this, we initialize the real_usage string with 0s. > > > > Philipp Jungkamp created this fix, I'm simply submitting it. I've > > verified it fixes bugzilla issue 217169 > > > > Reported-and-tested-by: Todd Brandt <todd.e.brandt@xxxxxxxxxxxxxxx> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217169 > > Signed-off-by: Todd Brandt <todd.e.brandt@xxxxxxxxx> > > Why is not Philip in the SoB list? > Oh, sorry, I got feedback and assumed it needed more work on the changelog. I also forgot to copy over Phillip's SoB line so this one is probably worse than the original. The original was just fine, please ignore this one. > Anyway the original patch made it to stable, so: > > Fixes: 98c062e82451 ("HID: hid-sensor-custom: Allow more custom iio > sensors") > Cc: stable@xxxxxxxxxxxxxxx > > and with those you can add: > > Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> > > Andi
