On 10.03.2023 11:41, 慕冬亮 wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> -----原始邮件-----
>> 发件人: Claudiu.Beznea@xxxxxxxxxxxxx
>> 发送时间: 2023-03-10 17:14:56 (星期五)
>> 收件人: chengziqiu@xxxxxxxxxxx, eugen.hristev@xxxxxxxxxxxxx, jic23@xxxxxxxxxx, lars@xxxxxxxxxx, Nicolas.Ferre@xxxxxxxxxxxxx, alexandre.belloni@xxxxxxxxxxx
>> 抄送: dzm91@xxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
>> 主题: Re: [PATCH] drivers: iio: remove dead code in at91_adc_probe
>>
>> On 09.03.2023 17:05, Cheng Ziqiu wrote:
>>> >From the comment of platform_get_irq, it only returns non-zero IRQ
>>> number and negative error number, other than zero.
>>>
>>> Fix this by removing the if condition.
>>>
>>> Signed-off-by: Cheng Ziqiu <chengziqiu@xxxxxxxxxxx>
>>
>> I see From and 1st SoB matches but
>>
>>> Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
>>
>> this SoB seems extra. What is the contribution of Dongliang Mu to this patch?
>
> I reviewed this patch locally since this student is the first time to submit patch to the kernel mailing list.
Then please use "Reviewed-by" tag.
>
> In my lab, I encourage all students to fix kernel issues. However, their patches should be reviewed by me first before sending the mailing list.
>
>>
>>> ---
>>> drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
>>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
>>> index 50d02e5fc6fc..168399092590 100644
>>> --- a/drivers/iio/adc/at91-sama5d2_adc.c
>>> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
>>> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
>>> st->dma_st.phys_addr = res->start;
>>>
>>> st->irq = platform_get_irq(pdev, 0);
>>> - if (st->irq <= 0) {
>>> - if (!st->irq)
>>> - st->irq = -ENXIO;
>>> -
>>> + if (st->irq < 0)
>>> return st->irq;
>>> - }
>>>
>>> st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
>>> if (IS_ERR(st->per_clk))
>>> --
>>> 2.34.1
>>>
>>
>
>
> --
> Best regards,
> Dongliang Mu
