Hi Jonathan, Please, see my comments below... On Sat, 2023-02-25 at 17:11 +0000, Jonathan Cameron wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, 20 Feb 2023 14:32:30 +0200 > <marius.cristea@xxxxxxxxxxxxx> wrote: > > > From: Marius Cristea <marius.cristea@xxxxxxxxxxxxx> > > > > Adding support for Microchip PAC193X series of Power Monitor with > > Accumulator chip family. > > This device is at the messy boundary between IIO and HWMON. Perhaps > call out > the reasons you think IIO is more appropriate in this cover letter. > + Often a good idea for these borderline parts to cc both mailing > lists and > maintainers. > > Often the conclusion is that it is fine to have these in IIO because > we can > bridge to hwmon anyway with the iio-hwmon driver. > Indeed the driver (the device) is at the boundary between IIO and HWMON. I was thinking to start with a simple driver (this one that is more apropiate to be a HWMON) and add more functionality later (like data buffering that is quite important for example if someone wants to profile power consumtion of the procesor itself, or a pheriperic, or a battery) > > > > Differences related to previous patch: > > > > v1: > > - first version comitted to review > > > > > > Marius Cristea (2): > > dt-bindings: iio: adc: adding dt-bindings for PAC193X > > iio: adc: adding support for pac193x > > > > .../bindings/iio/adc/microchip,pac193x.yaml | 122 + > > MAINTAINERS | 7 + > > drivers/iio/adc/Kconfig | 12 + > > drivers/iio/adc/Makefile | 1 + > > drivers/iio/adc/pac193x.c | 2072 > > +++++++++++++++++ > > 5 files changed, 2214 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/iio/adc/microchip,pac193x.yaml > > create mode 100644 drivers/iio/adc/pac193x.c > > > Thanks, Marius
