On 04/03/2023 19:59, Andrew Hepp wrote: > Add support for the MCP9600 thermocouple EMF converter. > Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > Datasheet: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf > Signed-off-by: Andrew Hepp <andrew.hepp@xxxxxxxxx> > --- > Changes for v4: > - use descriptive names for open/short circuit interrupts > - remove vdd regulator description > - remove unused import > - use generic sensor name in example > - don't use literal style for doc description > Changes for v3: > - Added dt-bindings > --- > .../iio/temperature/microchip,mcp9600.yaml | 70 ++++++++++++++++++ > microchip,mcp9600.yaml | 72 +++++++++++++++++++ Your patch is corrupted/second file does not make sense. > 2 files changed, 142 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml > create mode 100644 microchip,mcp9600.yaml > > diff --git a/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml > new file mode 100644 > index 000000000000..5916d331e759 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/temperature/microchip,mcp9600.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/temperature/microchip,mcp9600.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip MCP9600 thermocouple EMF converter > + > +maintainers: > + - Andrew Hepp <andrew.hepp@xxxxxxxxx> > + > +description: > + https://ww1.microchip.com/downloads/en/DeviceDoc/MCP960X-Data-Sheet-20005426.pdf > + > +properties: > + compatible: > + const: microchip,mcp9600 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 6 > + > + interrupt-names: > + minItems: 1 > + maxItems: 6 > + items: > + enum: > + - open-circuit > + - short-circuit > + - alert1 > + - alert2 > + - alert3 > + - alert4 > + > + thermocouple-type: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Type of thermocouple (THERMOCOUPLE_TYPE_K if omitted). > + Use defines in dt-bindings/iio/temperature/thermocouple.h. > + Supported types are B, E, J, K, N, R, S, T. > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false I missed this one - this should be instead additionalProperties: false Best regards, Krzysztof
