On Sat, Mar 04, 2023 at 04:46:01PM +0000, Jonathan Cameron wrote: > On Thu, 2 Mar 2023 14:04:35 +0100 > Mehdi Djait <mehdi.djait.k@xxxxxxxxx> wrote: > > > Move the kernel-doc of the function to industrialio-trigger.c > > Add a note on the context where the function is expected to be called. > > > > Signed-off-by: Mehdi Djait <mehdi.djait.k@xxxxxxxxx> > > --- > > v2: > > - Changed the expected context of from interrupt to hard IRQ context > > > > drivers/iio/industrialio-trigger.c | 7 +++++++ > > include/linux/iio/trigger.h | 6 ------ > > 2 files changed, 7 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c > > index a2f3cc2f65ef..bb0a44df8740 100644 > > --- a/drivers/iio/industrialio-trigger.c > > +++ b/drivers/iio/industrialio-trigger.c > > @@ -192,6 +192,13 @@ static void iio_trigger_notify_done_atomic(struct iio_trigger *trig) > > schedule_work(&trig->reenable_work); > > } > > > > +/** > > + * iio_trigger_poll() - Call the IRQ trigger handler of the consumers > > + * @trig: trigger which occurred > > + * > > + * This function needs to be called from a hard IRQ context. > I tweaked this to drop the line below and to say > This function should only be called from a hard IRQ context. > > Fun subtlety of English that reminds me of the sign on the London underground > escalators that said "Guide dogs must be carried" thus apparently limiting > their use to people who could find a guide dog to carry. > > Here we don't want to oblige all code to call the function :) I was even going for "must be called from hard IRQ context" first :) but then decided that I need more accepted patches before instructing others on what must be done in the kernel :) -- Kind Regards Mehdi Djait
