Hello Andy, On Tue, Feb 28, 2023 at 12:50:06AM +0200, Andy Shevchenko wrote: > On Mon, Feb 27, 2023 at 07:00:38PM +0100, Mehdi Djait wrote: > > Move the kernel-doc of the function to industrialio-trigger.c > > Add a note on the context where the function is expected to be called. > > ... > > > + * This function needs to be called from an interrupt context. > > > - * Typically called in relevant hardware interrupt handler. > > These are not equivalent. Can you explain in the commit message why we move > from hardware to any interrupt context? I read the definition of handle_irq_desc more carefully and [1]. I will change it to hard IRQ context. I got confused by the kernel-docs under /kernel/irq/irqdesc.c as it states that the function must be called from an IRQ context for generic_handle_irq but explicitly states hard IRQ context for another funtion. [1] https://lore.kernel.org/all/1346922337-17088-1-git-send-email-lars@xxxxxxxxxx/ -- Kind Regards Mehdi Djait
