On Sun, 19 Feb 2023 22:05:16 +0100 Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > Hello Uwe, > > I think there's a typo in the subject line: > s/releaseing/releasing/ > > On Sun, Feb 19, 2023 at 9:44 PM Uwe Kleine-König > <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > > > meson_sar_adc_lock() might return an error if BL30 doesn't release its > > lock on the hardware. Just returning early from .remove() is wrong > > however as this keeps the clocks and regulators on which is never > > cleaned up later. > > > > Given the BL30 not giving up its lock is a strong hint for broken > > behaviour, and there is nothing we can do about that: Just clean up > > ignoring the fact that we're not holding the lock. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Other than the typo (which maybe Jonathan can fix up while applying): > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> Fixed up typo and applied to the togreg branch of iio.git. Note I'll not push that out other than as testing until I can rebase on rc1. Thanks, Jonathan > > > Thank you! > Martin
