Hello Lorenzo and Jonathan, On Mon, Feb 20, 2023 at 10:12:29AM +0100, Lorenzo Bianconi wrote: > On Sat, Feb 18, 2023 at 01:56:22PM +0000, Jonathan Cameron wrote: > > > On Wed, 8 Feb 2023 15:42:31 +0100 > > Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote: > > > > > During digital filters settling time the driver is expected to drop > > > samples since they can be corrupted. Introduce the capability to drop > > > a given number of samples according to the configured ODR. > > > Add the sample_to_discard data for LSM6DSM sensor. > > > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > > > > Is this only necessary for the particular sensor you have provided > > values for? Or is it more general? > > > > I think the code will currently just set the number of samples to discard > > to 0 for other cases (as no value set for those sensor types). > > That's fine if 0 is definitely the right value for those other sensors. > > I think all the sensors have this information in the datasheet/application > note. However, even if we add sample_to_discard just for LSM6DSM for the moment, > we do not introduce any regression for the other sensors with respect to the > previous codebase since sample_to_discard will be just set to 0 (so we do not > discard any sample). I can add sample_to_discard for LSM6DSO but at the > moment I do not have other devices for testing. > For LSM6DSO, do you prefer to add it in v2 or is it fine a follow-up patch? How comes your patch really drops samples on my st,ism330dlc IMU ? Best regards Philippe
