On Sun, 5 Feb 2023 14:57:59 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Mon, 30 Jan 2023 11:41:31 -0800 > Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > Quoting Gwendal Grignou (2023-01-28 16:37:53) > > > Older firmwares still send sensor configuration using a list of > > > registers with opaque values defined during sensor tuning. > > > sx9234 and sx9360 sensor on ACPI based devices are concerned. > > > More schema to configure the sensors will be needed to support devices > > > designed for windows, like Samsung Galaxy Book2. > > > > > > Support schema is: "<_HID>.<register_name>". For instance > > > "STH9324,reg_adv_ctrl2" in: > > > > > > Scope (\_SB.PCI0.I2C2) > > > { > > > Device (SX28) > > > { > > > Name (_HID, "STH9324") // _HID: Hardware ID > > > ... > > > Name (_DSD, Package (0x02) // _DSD: Device-Specific Data > > > { > > > ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* > > > Device Properties for _DSD */, > > > Package (0x3F) > > > { > > > ... > > > Package (0x02) > > > { > > > "STH9324,reg_adv_ctrl2", > > > Zero > > > },` > > > > > > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > > > --- > > > > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > Applied to the togreg branch of iio.git and pushed out as testing. > > Timing wise, we are late in the cycle so this might not make it upstream > until next cycle. > Dropped for now as we need to fix an issue with acpi_device_hid() not being defined with !CONFIG_ACPI that broke some builds in next. Jonathan > Thanks, > > Jonathan >