Re: [PATCH v2] iio: light: vcnl4000: Fix WARN_ON on uninitialized lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/31/23 14:37, Andy Shevchenko wrote:
On Tue, Jan 31, 2023 at 02:27:51PM +0100, Mårten Lindahl wrote:
On 1/31/23 13:33, Andy Shevchenko wrote:
On Tue, Jan 31, 2023 at 11:29:51AM +0100, Mårten Lindahl wrote:
...

   - Trimmed backtrace in commit message
Not enough, please try harder. The ideal is to have ~3-5 lines of traceback.
Hi Andy, Maybe I get it right soon ;). Could it perhaps be stripped like
this?
Lockdep warning is important.

Assuming you left the warning still in place, almost there.

Call trace:
__mutex_lock
mutex_lock_nested
vcnl4200_set_power_state
vcnl4200_init
vcnl4000_probe
Can be cut out:
Ok, I'll have it like this then:

  DEBUG_LOCKS_WARN_ON(lock->magic != lock)
  at kernel/locking/mutex.c:575 __mutex_lock+0x4f8/0x890
  Call trace:
  __mutex_lock
  mutex_lock_nested
  vcnl4200_set_power_state
  vcnl4200_init
  vcnl4000_probe

Kind regards

Mårten


i2c_device_probe



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux